[Mesa-dev] [PATCH] radv: add radv_clear_{cmask,dcc} helpers

[Samuel Pitoiset]

On 04/06/2018 02:35 PM, Emil Velikov wrote:
> On 6 April 2018 at 11:25, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:
> 
>> --- a/src/amd/vulkan/radv_meta.h
>> +++ b/src/amd/vulkan/radv_meta.h
>> @@ -195,6 +195,11 @@ void radv_blit_to_prime_linear(struct radv_cmd_buffer *cmd_buffer,
>>                                 struct radv_image *image,
>>                                 struct radv_image *linear_image);
>>
>> +uint32_t radv_clear_cmask(struct radv_cmd_buffer *cmd_buffer,
>> +                         struct radv_image *image, uint32_t value);
>> +uint32_t radv_clear_dcc(struct radv_cmd_buffer *cmd_buffer,
>> +                       struct radv_image *image, uint32_t value);
>> +
>>   /* common nir builder helpers */
>>   #include "nir/nir_builder.h"
>>
> Unrelated comment:
> 
> Having an include in the middle of the header is normally a bad idea.
> Here this creates the 'extern "C" { #include "..." }' pattern which
> should be avoided.

I do agree. We should probably try to remove it.

> 
> HTH
> Emil
>