[Mesa-dev] [PATCH] radv: fix prefetching of vertex shader and VBOs on SI

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Mon Apr 9 12:39:53 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Mon, Apr 9, 2018 at 2:38 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Forgot one check... Too many mistakes for a simple change.
>
> Fixes: f1d7c16e85 ("radv: fix prefetching compute shaders on CIK and older chips")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105952
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index e8a6d9be15..6cd798dbfc 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -3083,7 +3083,7 @@ radv_draw(struct radv_cmd_buffer *cmd_buffer,
>                  */
>                 si_emit_cache_flush(cmd_buffer);
>
> -               if (cmd_buffer->state.prefetch_L2_mask) {
> +               if (has_prefetch && cmd_buffer->state.prefetch_L2_mask) {
>                         /* Only prefetch the vertex shader and VBO descriptors
>                          * in order to start the draw as soon as possible.
>                          */
> --
> 2.17.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list