[Mesa-dev] [PATCH 1/4] ac/surface: don't set the display flag for obviously unsupported cases (v2)

[Michel Dänzer]

On 2018-04-06 07:12 PM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> This enables the tile swizzle for some cases of the displayable micro mode,
> and it also fixes an addrlib assertion failure on Vega.

[...]

> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
> index dd3189c67d0..ef6f1072abd 100644
> --- a/src/amd/vulkan/radv_image.c
> +++ b/src/amd/vulkan/radv_image.c
> @@ -919,20 +919,21 @@ radv_image_create(VkDevice _device,
>  	if (!image)
>  		return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
>  
>  	image->type = pCreateInfo->imageType;
>  	image->info.width = pCreateInfo->extent.width;
>  	image->info.height = pCreateInfo->extent.height;
>  	image->info.depth = pCreateInfo->extent.depth;
>  	image->info.samples = pCreateInfo->samples;
>  	image->info.array_size = pCreateInfo->arrayLayers;
>  	image->info.levels = pCreateInfo->mipLevels;
> +	image->info.num_channels = 4; /* TODO: set this correctly */

Maybe a radv developer can suggest something here? Anyway,

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer