[Mesa-dev] [PATCH] glsl: properly handle bindless sampler and image parameters

Karol Herbst kherbst at redhat.com
Tue Apr 10 14:23:17 UTC 2018


fixes a piglit test I sent to the list:
spec at arb_bindless_texture@execution at samplers@basic-arithmetic-func-call-uvec2-texture2D

Signed-off-by: Karol Herbst <kherbst at redhat.com>
---
 src/compiler/glsl/opt_function_inlining.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/glsl/opt_function_inlining.cpp b/src/compiler/glsl/opt_function_inlining.cpp
index 04690b6cf45..3d00074bbc3 100644
--- a/src/compiler/glsl/opt_function_inlining.cpp
+++ b/src/compiler/glsl/opt_function_inlining.cpp
@@ -155,7 +155,7 @@ ir_call::generate_inline(ir_instruction *next_ir)
       ir_rvalue *param = (ir_rvalue *) actual_node;
 
       /* Generate a new variable for the parameter. */
-      if (sig_param->type->contains_opaque()) {
+      if (!sig_param->contains_bindless() && sig_param->type->contains_opaque()) {
 	 /* For opaque types, we want the inlined variable references
 	  * referencing the passed in variable, since that will have
 	  * the location information, which an assignment of an opaque
-- 
2.14.3



More information about the mesa-dev mailing list