[Mesa-dev] [PATCH v2 11/12] meson: build tests for gallium mesa state tracker

Dylan Baker dylan at pnwbakers.com
Tue Apr 10 20:10:27 UTC 2018


Quoting Eric Anholt (2018-04-10 11:05:03)
> Dylan Baker <dylan at pnwbakers.com> writes:
> 
> > Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
> > ---
> >  src/mesa/state_tracker/tests/meson.build | 40 +++++++++++++++++++++++++-
> >  src/meson.build                          |  3 ++-
> >  2 files changed, 43 insertions(+)
> >  create mode 100644 src/mesa/state_tracker/tests/meson.build
> >
> > diff --git a/src/mesa/state_tracker/tests/meson.build b/src/mesa/state_tracker/tests/meson.build
> > new file mode 100644
> > index 0000000..f62039e
> > --- /dev/null
> > +++ b/src/mesa/state_tracker/tests/meson.build
> > @@ -0,0 +1,40 @@
> > +# Copyright © 2018 Intel Corporation
> > +
> > +# Permission is hereby granted, free of charge, to any person obtaining a copy
> > +# of this software and associated documentation files (the "Software"), to deal
> > +# in the Software without restriction, including without limitation the rights
> > +# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> > +# copies of the Software, and to permit persons to whom the Software is
> > +# furnished to do so, subject to the following conditions:
> > +
> > +# The above copyright notice and this permission notice shall be included in
> > +# all copies or substantial portions of the Software.
> > +
> > +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> > +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> > +# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> > +# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> > +# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> > +# SOFTWARE.
> > +
> > +libmesa_st_test_common = static_library(
> > +  'mesa_st_test_common',
> > +  ['st_tests_common.cpp', ir_expression_operation_h],
> > +  include_directories : inc_common,
> > +  dependencies : dep_thread,
> > +)
> > +
> > +test(
> > +  'st_renumerate_test',
> > +  executable(
> > +    'st_renumerate_test',
> > +    ['test_glsl_to_tgsi_lifetime.cpp', ir_expression_operation_h],
> > +    include_directories : inc_common,
> > +    link_with : [
> > +      libmesa_st_test_common, libmesa_gallium, libglapi, libgallium,
> > +      libmesa_util,
> > +    ],
> > +    dependencies : [idep_gtest, dep_thread, dep_llvm]
> > +  )
> > +)
> > diff --git a/src/meson.build b/src/meson.build
> > index 1900527..03b0656 100644
> > --- a/src/meson.build
> > +++ b/src/meson.build
> > @@ -80,6 +80,9 @@ if with_egl
> >  endif
> >  if with_gallium
> >    subdir('gallium')
> > +  # This has to be here since it requires libgallium, and subdir cannot
> > +  # contains ..
> 
> "contain"
> 
> other than that, patches 2, 6-8, 11-12 get my r-b.
> 
> I don't think I'm going to find time to read all the python in patch 3.
> If nobody else does in the next week or so, I think we should just put
> my a-b on it and r-b on 4-5, and call it good.

Thanks for looking at these. I've fixed the typo locally. If no one looks at
these in the next week or so I'll just push them as-is.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180410/89273cfa/attachment.sig>


More information about the mesa-dev mailing list