[Mesa-dev] [PATCH 3/3] nir: simplify node matching code when lowering to SSA

[Caio Marcelo de Oliveira Filho]

On Tue, Apr 10, 2018 at 10:15:45PM -0700, Jason Ekstrand wrote:
> On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho <
> caio.oliveira at intel.com> wrote:
> 
> > The matching code doesn't make real use of the return value. The main
> > function return value is ignored, and while the worker function
> > propagate its return value, the actual callback never returns false.
> >
> 
> When I wrote this, I don't think I realized it was only going to have the
> one use.  I was mostly following the pattern we'd used for all the other
> foreach functions in NIR.  That said, I think this is better.

I guessed that was the case.


> When a block contains multiple lines, we use { } regardless of whether or
> not it's just a single statement.

Got it!

Will send v2 soon.


Thanks,
Caio