[Mesa-dev] [PATCH 7/7] i965: Record mipmap resolver for unmapping

Scott D Phillips scott.d.phillips at intel.com
Thu Apr 12 14:45:03 UTC 2018


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Quoting Scott D Phillips (2018-04-12 15:17:16)
>> Chris Wilson <chris at chris-wilson.co.uk> writes:
>> 
>> > When mapping a region of the mipmap_tree, record which complementary
>> > method to use to unmap it afterwards. By doing so we can avoid
>> > duplicating the decision tree used when mapping and thereby eliminate
>> > trivial errors that can be introduced if the two if-chains become out of
>> > sync.
>> >
>> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>> > Cc: Kenneth Graunke <kenneth at whitecape.org>
>> > Cc: Scott D Phillips <scott.d.phillips at intel.com>
>> 
>> for the series
>> 
>> Reviewed-by: Scott D Phillips <scott.d.phillips at intel.com>
>
> Does it fit into your work neatly, and if so do you want to submit them
> together? I was hoping having just one decision tree to update, should
> help the WC refactoring.

Yes, I do like this change for that series. I'll put my patches on top
of this and submit them together. Thanks for that,

-- 
Scott


More information about the mesa-dev mailing list