[Mesa-dev] [PATCH 01/10] radv: disable prediction only if it has been enabled

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Mon Apr 16 09:48:57 UTC 2018


Reviewed-by: Bas Niuwenhuizen <bas at basnieuwenhuizen.nl>

for the series. Thanks for the cleanup.

On Fri, Apr 13, 2018 at 7:14 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> When decompressing DCC we don't enable it, so it's useless
> to disable it. This reduces the number of prediction packets
> sent to the GPU when performing color decompression passes.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_meta_fast_clear.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c
> index 327c1ae440..d5af7a1b0c 100644
> --- a/src/amd/vulkan/radv_meta_fast_clear.c
> +++ b/src/amd/vulkan/radv_meta_fast_clear.c
> @@ -667,7 +667,7 @@ radv_emit_color_decompress(struct radv_cmd_buffer *cmd_buffer,
>                                         &cmd_buffer->pool->alloc);
>
>         }
> -       if (radv_image_has_dcc(image)) {
> +       if (!decompress_dcc && radv_image_has_dcc(image)) {
>                 cmd_buffer->state.predicating = false;
>                 radv_emit_set_predication_state_from_image(cmd_buffer, image, false);
>         }
> --
> 2.17.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list