[Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

[Dylan Baker]

Quoting Jan Alexander Steffens (heftig) (2018-04-14 10:23:20)
> This is for parity with autotools. We were suddenly getting assertion
> failures after switching to meson, see [1].
> 
> [1]: https://bugs.archlinux.org/task/58218
> 
> Signed-off-by: Jan Alexander Steffens (heftig) <jan.steffens at gmail.com>
> ---
>  meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index a4dfa62255..931e0389e6 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -705,6 +705,8 @@ endif
>  # Define DEBUG for debug builds only (debugoptimized is not included on this one)
>  if get_option('buildtype') == 'debug'
>    pre_args += '-DDEBUG'
> +else
> +  pre_args += '-DNDEBUG'
>  endif
>  
>  if get_option('shader-cache')
> -- 
> 2.16.2

NAK.

meson has -Db_ndebug for controlling NDEBUG, which is done separately from
optimization levels, this is in our documentation as well as the meson
documentation. For builds without asserts, set b_ndebug=true.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180416/3999e170/attachment-0001.sig>