[Mesa-dev] [PATCH 2/2] radv: make sure to sync after resolving using the compute path

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Wed Apr 18 12:51:58 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Tue, Apr 17, 2018 at 3:08 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> This fixes some random CTS failures:
>
> dEQP-VK.renderpass.multisample.*.
>
> Performing a fast-clear eliminate is still useless, but it
> seems that we need to sync.
>
> Found while running CTS with RADV_DEBUG=zerovram.
>
> Fixes: 56a171a499c ("radv: don't fast-clear eliminate after resolving a subpass with compute")
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_meta_resolve_cs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_meta_resolve_cs.c b/src/amd/vulkan/radv_meta_resolve_cs.c
> index 628208d6356..ede55f6d005 100644
> --- a/src/amd/vulkan/radv_meta_resolve_cs.c
> +++ b/src/amd/vulkan/radv_meta_resolve_cs.c
> @@ -516,5 +516,8 @@ radv_cmd_buffer_resolve_subpass_cs(struct radv_cmd_buffer *cmd_buffer)
>                              &(VkExtent2D) { fb->width, fb->height });
>         }
>
> +       cmd_buffer->state.flush_bits |= RADV_CMD_FLAG_CS_PARTIAL_FLUSH |
> +                                       RADV_CMD_FLAG_INV_VMEM_L1;
> +
>         radv_meta_restore(&saved_state, cmd_buffer);
>  }
> --
> 2.17.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list