[Mesa-dev] [PATCH 1/2] radv: enable/disable prediction for the DCC decompression pass

[Nicolai Hähnle]

s/prediction/predication/ ? :)

On 18.04.2018 14:34, Samuel Pitoiset wrote:
> Performing a DCC decompression pass is currently pretty rare,
> but using prediction allows the GPU to skip unnecessary passes.
> 
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/amd/vulkan/radv_meta_fast_clear.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c
> index d5af7a1b0c..e702dc80a5 100644
> --- a/src/amd/vulkan/radv_meta_fast_clear.c
> +++ b/src/amd/vulkan/radv_meta_fast_clear.c
> @@ -601,7 +601,7 @@ radv_emit_color_decompress(struct radv_cmd_buffer *cmd_buffer,
>                  pipeline = cmd_buffer->device->meta_state.fast_clear_flush.cmask_eliminate_pipeline;
>   	}
>   
> -	if (!decompress_dcc && radv_image_has_dcc(image)) {
> +	if (radv_image_has_dcc(image)) {
>   		radv_emit_set_predication_state_from_image(cmd_buffer, image, true);
>   		cmd_buffer->state.predicating = true;
>   	}
> @@ -667,7 +667,7 @@ radv_emit_color_decompress(struct radv_cmd_buffer *cmd_buffer,
>   					&cmd_buffer->pool->alloc);
>   
>   	}
> -	if (!decompress_dcc && radv_image_has_dcc(image)) {
> +	if (radv_image_has_dcc(image)) {
>   		cmd_buffer->state.predicating = false;
>   		radv_emit_set_predication_state_from_image(cmd_buffer, image, false);
>   	}
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.