[Mesa-dev] [PATCH 1/3] Autotools: include include/vulkan headers

[Kenneth Graunke]

On Friday, April 20, 2018 7:19:49 PM PDT Dylan Baker wrote:
> Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
> ---
>  Makefile.am | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index a83f2bcb5f4..a4ff647f418 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -67,7 +67,7 @@ EXTRA_DIST = \
>  	bin/install_megadrivers.py \
>  	bin/meson_get_version.py
>  
> -noinst_HEADERS = \
> +noinst_HEADERS = include

This can't work, without a terminating \ you'll just drop the rest of
the list.  Looks like a typo, but would probably break all autotools
builds.  Please drop this hunk and re-test at least a simple build.

>  	include/c99_alloca.h \
>  	include/c99_compat.h \
>  	include/c99_math.h \
> @@ -82,7 +82,8 @@ noinst_HEADERS = \
>  	include/GL/wglext.h \
>  	include/HaikuGL \
>  	include/no_extern_c.h \
> -	include/pci_ids
> +	include/pci_ids \
> +	include/vulkan

I'm not sure off-hand what caused this to be necessary - it would be
nice to note that in the commit message.  Still, it seems pretty
harmless.

With only the second hunk,
Acked-by: Kenneth Graunke <kenneth at whitecape.org>

>  
>  # We list some directories in EXTRA_DIST, but don't actually want to include
>  # the .gitignore files in the tarball.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180420/6691eaca/attachment.sig>