[Mesa-dev] [PATCH 2/2] i965/blorp: Also skip the fast clear if the clear color differs

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Wed, Apr 11, 2018 at 1:56 PM, Nanley Chery <nanleychery at gmail.com> wrote:

> If the aux state is CLEAR and clear color value has changed, only the
> surface state must be updated. The bit-pattern in the aux buffer is
> exactly the same.
>
> v2: Handle the indirect color on gen10+.
> ---
>  src/mesa/drivers/dri/i965/brw_blorp.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c
> b/src/mesa/drivers/dri/i965/brw_blorp.c
> index 48022bb1c4f..52fec02174d 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp.c
> +++ b/src/mesa/drivers/dri/i965/brw_blorp.c
> @@ -1232,11 +1232,14 @@ do_single_blorp_clear(struct brw_context *brw,
> struct gl_framebuffer *fb,
>        bool same_clear_color =
>           !intel_miptree_set_clear_color(brw, irb->mt,
> &ctx->Color.ClearColor);
>
> -      /* If the buffer is already in INTEL_FAST_CLEAR_STATE_CLEAR, the
> clear
> +      /* If the buffer is already in ISL_AUX_STATE_CLEAR, the clear
>         * is redundant and can be skipped.
>         */
> -      if (aux_state == ISL_AUX_STATE_CLEAR && same_clear_color)
> +      if (aux_state == ISL_AUX_STATE_CLEAR) {
> +         if (!same_clear_color)
> +            intel_miptree_update_indirect_color(brw, irb->mt);
>           return;
> +      }
>
>        DBG("%s (fast) to mt %p level %d layers %d+%d\n", __FUNCTION__,
>            irb->mt, irb->mt_level, irb->mt_layer, num_layers);
> --
> 2.16.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180423/404f4144/attachment.html>