[Mesa-dev] [PATCH] egl/android: remove flink name support

[Emil Velikov]

Hi Rob,

Thanks for doing this.

There's a couple of small nits, but the patch looks good IMHO.
On the topic of keeping the old code behind a #define or just removing
it, it'll be great if interested parties can reach a consensus.


On 19 April 2018 at 22:09, Rob Herring <robh at kernel.org> wrote:

> --- a/src/egl/drivers/dri2/egl_dri2.h
> +++ b/src/egl/drivers/dri2/egl_dri2.h
> @@ -61,7 +61,6 @@ struct zwp_linux_dmabuf_v1;
>
>  #include <system/window.h>
>  #include <hardware/gralloc.h>
> -#include <gralloc_drm_handle.h>
>
>  #endif /* HAVE_ANDROID_PLATFORM */
>
Unrelated, future patch:
By adding a couple of fwd declarations, this whole hunk can be moved
to platform_android.c


> +enum {
> +        /* perform(const struct gralloc_module_t *mod,
> +         *         int op,
> +         *         int *fd);
> +         */
> +        GRALLOC_MODULE_PERFORM_GET_DRM_FD                = 0x40000002,
> +};
> +
Might want as well add a comment what/why. Say:
Add a local definition to avoid depending on ...


> @@ -1216,17 +1081,14 @@ dri2_initialize_android(_EGLDriver *drv, _EGLDisplay *disp)
>     /* render nodes cannot use Gem names, and thus do not support
>      * the __DRI_DRI2_LOADER extension */
With the __DRI_DRI2_LOADER hunk removed above, the comment needs an update.

HTH
Emil