[Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

[Dieter Nützel]

Am 31.07.2018 13:34, schrieb Timothy Arceri:
> On 31/07/18 13:50, Dieter Nützel wrote:
>> Am 30.07.2018 05:24, schrieb Dieter Nützel:
>>> For the series
>>> 
>>> Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
>>> 
>>> with glmark2, glxgears, UH, UV, Blender 2.79 and FreeCAD 0.17
>>> 
>>> on RX 580.
>>> 
>>> With UH I saw some small light blue triangles spreading around.
>>> Have to bisect which patch set was the culprit. (If I have some 
>>> time.)
>>> Tried your's above
>>> configure-bump-libdrm-for-AMDGPU-to-2.4.92.mbox (Samuel)
>>> ASTC-texture-compression-for-all-Gallium-drivers.mbox (Marek)
>>> 
>>> Dieter
>> 
>> It has something to do with tessellation.
>> If I disable it (F3) all small light blue triangles are _gone_.
> 
> Are you able to bisect?

In short, it has _nothing_ to do with _this_ series.
Tested on e6ff5ac446.
So my tb stands.

After some sleep (Nothern Germany is _very_ hot and _dry_ this year) 
I'll do my very best... ;-)

>> 
>> Regards,
>> Dieter
>> 
>>> Am 28.07.2018 03:07, schrieb Timothy Arceri:
>>>> On 28/07/18 11:06, Timothy Arceri wrote:
>>>>> Since we know what side of the branch we ended up on we can just
>>>>> replace the use with a constant.
>>>>> 
>>>>> All the spill changes in shader-db are from Dolphin uber shaders,
>>>>> despite some small regressions the change is clearly positive.
>>>>> 
>>>>> V2: insert new constant after any phis in the
>>>>>      use->parent_instr->type == nir_instr_type_phi path.
>>>> 
>>>> Meh this was meant to be V3
>>>> _______________________________________________
>>>> mesa-dev mailing list
>>>> mesa-dev at lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev