[Mesa-dev] [PATCH 01/12] util/list: Make some helpers take const lists

Ian Romanick idr at freedesktop.org
Wed Aug 1 18:49:52 UTC 2018


Yes, please!  I have a similar patch around somewhere that was waiting
for a user before sending.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 07/26/2018 08:59 AM, Jason Ekstrand wrote:
> They're all just querying things about the list and not mutating
> anything.
> ---
>  src/util/list.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/util/list.h b/src/util/list.h
> index 6edb7501109..09d1b4cae64 100644
> --- a/src/util/list.h
> +++ b/src/util/list.h
> @@ -72,7 +72,7 @@ static inline void list_addtail(struct list_head *item, struct list_head *list)
>      list->prev = item;
>  }
>  
> -static inline bool list_empty(struct list_head *list);
> +static inline bool list_empty(const struct list_head *list);
>  
>  static inline void list_replace(struct list_head *from, struct list_head *to)
>  {
> @@ -101,7 +101,7 @@ static inline void list_delinit(struct list_head *item)
>      item->prev = item;
>  }
>  
> -static inline bool list_empty(struct list_head *list)
> +static inline bool list_empty(const struct list_head *list)
>  {
>     return list->next == list;
>  }
> @@ -114,7 +114,7 @@ static inline bool list_is_singular(const struct list_head *list)
>     return list->next != NULL && list->next != list && list->next->next == list;
>  }
>  
> -static inline unsigned list_length(struct list_head *list)
> +static inline unsigned list_length(const struct list_head *list)
>  {
>     struct list_head *node;
>     unsigned length = 0;
> @@ -145,7 +145,7 @@ static inline void list_splicetail(struct list_head *src, struct list_head *dst)
>     dst->prev = src->prev;
>  }
>  
> -static inline void list_validate(struct list_head *list)
> +static inline void list_validate(const struct list_head *list)
>  {
>     struct list_head *node;
>     assert(list->next->prev == list && list->prev->next == list);
> 



More information about the mesa-dev mailing list