[Mesa-dev] [PATCH 3/6] kutil/queue: use util_snprintf() in util_queue_init

Andres Gomez agomez at igalia.com
Wed Aug 1 18:53:02 UTC 2018


Instead of plain snprintf(). To fix the MSVC 2013 build:

  Compiling src\util\u_queue.c ...
u_queue.c
src\util\u_queue.c(325) : warning C4013: 'snprintf' undefined; assuming extern returning int

...

mesautil.lib(u_queue.obj) : error LNK2001: unresolved external symbol _snprintf
scons: building terminated because of errors.

Fixes: b238e33bc9d ("kutil/queue: add a process name into a thread name")
Cc: Marek Olšák <marek.olsak at amd.com>
Cc: Brian Paul <brianp at vmware.com>
Cc: Roland Scheidegger <sroland at vmware.com>
Cc: Timothy Arceri <tarceri at itsqueeze.com>
Cc: Eric Engestrom <eric.engestrom at intel.com>
Signed-off-by: Andres Gomez <agomez at igalia.com>
---
 src/util/u_queue.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/util/u_queue.c b/src/util/u_queue.c
index be95d9eec3f..95cb543494e 100644
--- a/src/util/u_queue.c
+++ b/src/util/u_queue.c
@@ -322,10 +322,10 @@ util_queue_init(struct util_queue *queue,
    memset(queue, 0, sizeof(*queue));
 
    if (process_len) {
-      snprintf(queue->name, sizeof(queue->name), "%.*s:%s",
-               process_len, process_name, name);
+      util_snprintf(queue->name, sizeof(queue->name), "%.*s:%s",
+                    process_len, process_name, name);
    } else {
-      snprintf(queue->name, sizeof(queue->name), "%s", name);
+      util_snprintf(queue->name, sizeof(queue->name), "%s", name);
    }
 
    queue->flags = flags;
-- 
2.18.0



More information about the mesa-dev mailing list