[Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

Dylan Baker dylan at pnwbakers.com
Thu Aug 2 16:49:03 UTC 2018


Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Quoting Jon Turney (2018-08-02 06:58:07)
> With a sufficently recent meson, the following warning is produced:
> 
> WARNING: Passed invalid keyword argument "extra_args".
> WARNING: This will become a hard error in the future.
> 
> It seems that compiler.links(args:) is meant here.
> 
> Signed-off-by: Jon Turney <jon.turney at dronecode.org.uk>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 86a4a4ce6d..cbf88b5013 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -989,7 +989,7 @@ if cc.links('''
>        freelocale(loc);
>        return 0;
>      }''',
> -    extra_args : pre_args,
> +    args : pre_args,
>      name : 'strtod has locale support')
>    pre_args += '-DHAVE_STRTOD_L'
>  endif
> -- 
> 2.17.0
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180802/56dd244c/attachment.sig>


More information about the mesa-dev mailing list