[Mesa-dev] [PATCH 13/13] nir: Transform expressions of b2f(a) and b2f(b) to a == b

[Thomas Helland]

Patches 12 and 13 are:

Reviewed-by: Thomas Helland<thomashelland90 at gmail.com>

2018-08-02 20:19 GMT+02:00 Ian Romanick <idr at freedesktop.org>:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> All Gen7+ platforms had similar results. (Skylake shown)
> total instructions in shared programs: 14276886 -> 14276838 (<.01%)
> instructions in affected programs: 312 -> 264 (-15.38%)
> helped: 2
> HURT: 0
>
> total cycles in shared programs: 532578395 -> 532570985 (<.01%)
> cycles in affected programs: 682562 -> 675152 (-1.09%)
> helped: 374
> HURT: 4
> helped stats (abs) min: 2 max: 200 x̄: 20.39 x̃: 18
> helped stats (rel) min: 0.07% max: 11.64% x̄: 1.25% x̃: 1.28%
> HURT stats (abs)   min: 2 max: 114 x̄: 53.50 x̃: 49
> HURT stats (rel)   min: 0.06% max: 11.70% x̄: 5.02% x̃: 4.15%
> 95% mean confidence interval for cycles value: -21.30 -17.91
> 95% mean confidence interval for cycles %-change: -1.30% -1.06%
> Cycles are helped.
>
> Sandy Bridge
> total instructions in shared programs: 10488123 -> 10488075 (<.01%)
> instructions in affected programs: 336 -> 288 (-14.29%)
> helped: 2
> HURT: 0
>
> total cycles in shared programs: 150260379 -> 150260439 (<.01%)
> cycles in affected programs: 4726 -> 4786 (1.27%)
> helped: 0
> HURT: 2
>
> No changes on Iron Lake or GM45.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/compiler/nir/nir_opt_algebraic.py | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py
> index 87e370e891a..e7e5aeaed04 100644
> --- a/src/compiler/nir/nir_opt_algebraic.py
> +++ b/src/compiler/nir/nir_opt_algebraic.py
> @@ -183,6 +183,9 @@ optimizations = [
>     (('feq', ('fmul', ('b2f', a), ('b2f', b)), 0.0), ('inot', ('iand', a, b))),
>     (('feq', ('fmax', ('b2f', a), ('b2f', b)), 0.0), ('inot', ('iand', a, b))),
>     (('feq', ('bcsel', a, ('b2f', b), 0.0)   , 0.0), ('inot', ('iand', a, b))),
> +   (('feq', ('fadd', ('b2f', a), ('fneg', ('b2f', b))), 0.0), ('ieq', a, b)),
> +   (('feq',          ('b2f', a) ,          ('b2f', b) ),      ('ieq', a, b)),
> +   (('feq', ('fneg', ('b2f', a)), ('fneg', ('b2f', b))),      ('ieq', a, b)),
>
>     # -(b2f(a) + b2f(b)) < 0
>     # 0 < b2f(a) + b2f(b)
> --
> 2.14.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev