[Mesa-dev] [PATCH 2/2] travis: meson/Vulkan requires LLVM 6.0

[Juan A. Suarez Romero]

On Tue, 2018-08-07 at 16:20 +0100, Emil Velikov wrote:
> On 6 August 2018 at 11:17, Juan A. Suarez Romero <jasuarez at igalia.com> wrote:
> > RADV now requires LLVM 6.0.
> > 
> > Fixes: fd1121e8399 ("amd: remove support for LLVM 5.0")
> > CC: Marek Olšák <marek.olsak at amd.com>
> 
> It seem that something went wrong splitting this from 1/2 - not too sure.
> Regardless,
> 

Patch 1/2 affected the autotools target in Travis.

This one adds the missing piece in "meson Vulkan" target.

> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Aside:
> 
> > @@ -36,17 +36,19 @@ matrix:
> >          - LABEL="meson Vulkan"
> >          - BUILD=meson
> >          - MESON_OPTIONS="-Ddri-drivers=[] -Dgallium-drivers=[]"
> 
> Having the drivers as explicit lists, alike the autoconf build would
> be a good move.
> Think, subtle bugs in the meson logic, fallback to disabling FOO when
> dependencies are not met, etc.

I agree. I'll send a different patch for this.

> 
> > -        - LLVM_VERSION=5.0
> > +        - LLVM_VERSION=6.0
> >          - LLVM_CONFIG="llvm-config-${LLVM_VERSION}"
> >        addons:
> >          apt:
> >            sources:
> > -            - llvm-toolchain-trusty-5.0
> > +            - llvm-toolchain-trusty-6.0
> > +            # llvm-6 depends on gcc-4.9 which is not in main repo
> > +            - ubuntu-toolchain-r-test
> >            packages:
> >              # LLVM packaging is broken and misses these dependencies
> >              - libedit-dev
> 
> Is this still needed? Might be worth poking Debian people about it.
> 

Good question. I'll check it and send a patch if required.


	J.A.

> -Emil
>