[Mesa-dev] [PATCH v4 1/2] wayland/egl: initialize window surface size to window size

Chad Versace chadversary at chromium.org
Tue Aug 7 18:09:36 UTC 2018

On Tue 07 Aug 2018, Juan A. Suarez Romero wrote:
> When creating a windows surface with eglCreateWindowSurface(), the
> width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is
> invalid until buffers are updated (like calling glClear()).
> But according to EGL 1.5 spec, section 3.5.6 ("Surface Attributes"):
>   "Querying EGL_WIDTH and EGL_HEIGHT returns respectively the width and
>    height, in pixels, of the surface. For a window or pixmap surface,
>    these values are initially equal to the width and height of the
>    native window or pixmap with respect to which the surface was
>    created"
> This fixes dEQP-EGL.functional.color_clears.* CTS tests
> v2:
> - Do not modify attached_{width,height} (Daniel)
> - Do not update size on resizing window (Brendan)
> CC: Daniel Stone <daniel at fooishbar.org>
> CC: Brendan King <brendan.king at imgtec.com>
> CC: mesa-stable at lists.freedesktop.org
> Tested-by: Eric Engestrom <eric at engestrom.ch>
> ---
>  src/egl/drivers/dri2/platform_wayland.c | 3 +++
>  1 file changed, 3 insertions(+)

Hah. I just sent an equivalent patch to the list. I'll drop my patch.

Just for patch 1,
Reviewed-by: Chad Versace <chadversary at chromium.org>
Tested-by: Chad Versace <chadversary at chromium.org>

I don't fully understand attached_width,height. So no rb on patch 2.

More information about the mesa-dev mailing list