[Mesa-dev] [PATCH mesa] anv: set error in all failure paths

[Tapani Pälli]

Yep currently result is not set on this path;

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

On 08.08.2018 17:45, Eric Engestrom wrote:
> Cc: Jason Ekstrand <jason.ekstrand at intel.com>
> Fixes: 5b196f39bddc689742d3 "anv/pipeline: Compile to NIR in compile_graphics"
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
>   src/intel/vulkan/anv_pipeline.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c
> index 23af0f1c9248858d6762..4074c8fd364f9b815f83 100644
> --- a/src/intel/vulkan/anv_pipeline.c
> +++ b/src/intel/vulkan/anv_pipeline.c
> @@ -979,8 +979,10 @@ anv_pipeline_compile_graphics(struct anv_pipeline *pipeline,
>                                              &stages[s],
>                                              &stages[s].prog_data.base,
>                                              &stages[s].bind_map);
> -      if (stages[s].nir == NULL)
> +      if (stages[s].nir == NULL) {
> +         result = vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
>            goto fail;
> +      }
>      }
>   
>      /* Walk backwards to link */
>