[Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

[Ilia Mirkin]

Sorry, I thought I was answering your question.

If glTexBufferEXT is aliased to glTexBuffer (/glTexBufferARB), which
are already in the list of dispatch functions, you should not add the
aliased name, otherwise you'll get failures. I did not, however, check
if glTexBufferEXT is aliased in the dispatch tables. If it's not,
ignore what I said.

Cheers,

  -ilia

On Wed, Aug 8, 2018 at 11:56 AM, Marek Olšák <maraeo at gmail.com> wrote:
> What does that mean?
>
> Marek
>
> On Wed, Aug 8, 2018 at 9:05 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Aliased functions shouldn't be added separately to the function list.
>>
>> On Wed, Aug 8, 2018 at 1:42 AM, Marek Olšák <maraeo at gmail.com> wrote:
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> This is needed for exposing the samplerBuffer functions under
>>> EXT_gpu_shader4.
>>>
>>> glTexBufferEXT is defined in glapi, but "make check" fails.
>>> What am I doing wrong?
>>> ---
>>>  docs/relnotes/18.3.0.html               | 1 +
>>>  src/mesa/main/extensions_table.h        | 1 +
>>>  src/mesa/main/tests/dispatch_sanity.cpp | 1 +
>>>  3 files changed, 3 insertions(+)
>>>
>>> diff --git a/docs/relnotes/18.3.0.html b/docs/relnotes/18.3.0.html
>>> index 786145ad8da..6274c9147a1 100644
>>> --- a/docs/relnotes/18.3.0.html
>>> +++ b/docs/relnotes/18.3.0.html
>>> @@ -45,20 +45,21 @@ TBD.
>>>
>>>
>>>  <h2>New features</h2>
>>>
>>>  <p>
>>>  Note: some of the new features are only available with certain drivers.
>>>  </p>
>>>
>>>  <ul>
>>>  <li>GL_AMD_framebuffer_multisample_advanced on radeonsi.</li>
>>> +<li>GL_EXT_texture_buffer_object on i965, nv50, nvc0, r600, radeonsi.</li>
>>>  </ul>
>>>
>>>  <h2>Bug fixes</h2>
>>>
>>>  <ul>
>>>  <li>TBD</li>
>>>  </ul>
>>>
>>>  <h2>Changes</h2>
>>>
>>> diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h
>>> index bdba49d5380..5eb5c3278e9 100644
>>> --- a/src/mesa/main/extensions_table.h
>>> +++ b/src/mesa/main/extensions_table.h
>>> @@ -263,20 +263,21 @@ EXT(EXT_shadow_funcs                        , ARB_shadow
>>>  EXT(EXT_stencil_two_side                    , EXT_stencil_two_side                   , GLL,  x ,  x ,  x , 2001)
>>>  EXT(EXT_stencil_wrap                        , dummy_true                             , GLL,  x ,  x ,  x , 2002)
>>>  EXT(EXT_subtexture                          , dummy_true                             , GLL,  x ,  x ,  x , 1995)
>>>  EXT(EXT_tessellation_point_size             , ARB_tessellation_shader                ,  x ,  x ,  x ,  31, 2013)
>>>  EXT(EXT_tessellation_shader                 , ARB_tessellation_shader                ,  x ,  x ,  x ,  31, 2013)
>>>  EXT(EXT_texture                             , dummy_true                             , GLL,  x ,  x ,  x , 1996)
>>>  EXT(EXT_texture3D                           , dummy_true                             , GLL,  x ,  x ,  x , 1996)
>>>  EXT(EXT_texture_array                       , EXT_texture_array                      , GLL, GLC,  x ,  x , 2006)
>>>  EXT(EXT_texture_border_clamp                , ARB_texture_border_clamp               ,  x ,  x ,  x , ES2, 2014)
>>>  EXT(EXT_texture_buffer                      , OES_texture_buffer                     ,  x ,  x ,  x ,  31, 2014)
>>> +EXT(EXT_texture_buffer_object               , ARB_texture_buffer_object              , GLL, GLC,  x ,  x , 2007)
>>>  EXT(EXT_texture_compression_dxt1            , ANGLE_texture_compression_dxt          , GLL, GLC, ES1, ES2, 2004)
>>>  EXT(EXT_texture_compression_latc            , EXT_texture_compression_latc           , GLL,  x ,  x ,  x , 2006)
>>>  EXT(EXT_texture_compression_rgtc            , ARB_texture_compression_rgtc           , GLL, GLC,  x ,  x , 2004)
>>>  EXT(EXT_texture_compression_s3tc            , EXT_texture_compression_s3tc           , GLL, GLC,  x ,  x , 2000)
>>>  EXT(EXT_texture_cube_map                    , ARB_texture_cube_map                   , GLL,  x ,  x ,  x , 2001)
>>>  EXT(EXT_texture_cube_map_array              , OES_texture_cube_map_array             ,  x ,  x ,  x ,  31, 2014)
>>>  EXT(EXT_texture_edge_clamp                  , dummy_true                             , GLL,  x ,  x ,  x , 1997)
>>>  EXT(EXT_texture_env_add                     , dummy_true                             , GLL,  x ,  x ,  x , 1999)
>>>  EXT(EXT_texture_env_combine                 , dummy_true                             , GLL,  x ,  x ,  x , 2000)
>>>  EXT(EXT_texture_env_dot3                    , EXT_texture_env_dot3                   , GLL,  x ,  x ,  x , 2000)
>>> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
>>> index 449dd3652cc..a7562b766f3 100644
>>> --- a/src/mesa/main/tests/dispatch_sanity.cpp
>>> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
>>> @@ -499,20 +499,21 @@ const struct function common_desktop_functions_possible[] = {
>>>     { "glClearBufferuiv", 30, -1 },
>>>     { "glClearBufferfv", 30, -1 },
>>>     { "glClearBufferfi", 30, -1 },
>>>     { "glGetStringi", 30, -1 },
>>>
>>>     /* GL 3.1 */
>>>     { "glDrawArraysInstanced", 31, -1 },
>>>     { "glDrawElementsInstanced", 31, -1 },
>>>     { "glPrimitiveRestartIndex", 31, -1 },
>>>     { "glTexBuffer", 31, -1 },
>>> +   { "glTexBufferEXT", 31, -1 },
>>>
>>>     /* GL_ARB_texture_buffer_range */
>>>     { "glTexBufferRange", 43, -1 },
>>>
>>>     /* GL_ARB_shader_objects */
>>>     { "glDeleteObjectARB", 31, -1 },
>>>     { "glGetHandleARB", 31, -1 },
>>>     { "glDetachObjectARB", 31, -1 },
>>>     { "glCreateShaderObjectARB", 31, -1 },
>>>     { "glCreateProgramObjectARB", 31, -1 },
>>> --
>>> 2.17.1
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev