[Mesa-dev] [PATCH 2/4] loader: add loader_open_render_node(..)

[Emil Velikov]

On 9 August 2018 at 06:12, Christian Gmeiner
<christian.gmeiner at gmail.com> wrote:
> This helper is almost a 1:1 copy of tegra_open_render_node().
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> ---
>  src/loader/loader.c | 65 +++++++++++++++++++++++++++++++++++++++++++++
>  src/loader/loader.h |  3 +++
>  2 files changed, 68 insertions(+)
>
> diff --git a/src/loader/loader.c b/src/loader/loader.c
> index 43275484cc..60b5d71083 100644
> --- a/src/loader/loader.c
> +++ b/src/loader/loader.c
> @@ -83,6 +83,65 @@ loader_open_device(const char *device_name)
>  }
>
A few 'thinking out loud' comments:
 - worth keeping node type and bus type as arguments
 - using devices[64] will simplify/speed things up
 - s/open/loader_open_device/ to deal with funky O_CLOEXEC corner-cases

That can follow at a later stage. As-is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil