[Mesa-dev] [PATCH 1/4] tegra: fix memory leak

[Emil Velikov]

On 9 August 2018 at 12:20, Christian Gmeiner
<christian.gmeiner at gmail.com> wrote:
> Am Do., 9. Aug. 2018 um 12:23 Uhr schrieb Emil Velikov
> <emil.l.velikov at gmail.com>:
>>
>> On 9 August 2018 at 06:12, Christian Gmeiner
>> <christian.gmeiner at gmail.com> wrote:
>> > Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
>> > ---
>> >  src/gallium/drivers/tegra/tegra_screen.c | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/src/gallium/drivers/tegra/tegra_screen.c b/src/gallium/drivers/tegra/tegra_screen.c
>> > index 034ea271ee..361ec034de 100644
>> > --- a/src/gallium/drivers/tegra/tegra_screen.c
>> > +++ b/src/gallium/drivers/tegra/tegra_screen.c
>> > @@ -198,6 +198,7 @@ static int tegra_open_render_node(void)
>> >
>> >           version = drmGetVersion(fd);
>> >           if (!version) {
>> > +            drmFreeVersion(version);
>> This should be in the next if hunk - the strcmp() call.
>
> Yeah... that is what I wanted initially - but hacking to early in the
> morning (and in the train)
> does not seems to be my thing.
>
You've done it correctly on 2/4 so I'd imagine a shaky train got to you.

With that fixed, this patch is
Fixes: 1755f608f52 ("tegra: Initial support")
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks
Emil