[Mesa-dev] [PATCH] egl: Fix leak of X11 pixmaps backing pbuffers in DRI3.

[Emil Velikov]

On 7 August 2018 at 20:32, Eric Anholt <eric at anholt.net> wrote:
> This is basically copied from the DRI2 destroy path.  Without this,
> Raspberry Pi would quickly run out of CMA during the EGL tests in the CTS
> due to all the pixmaps laying around.
>
> Fixes: f35198badeb9 ("egl/x11: Implement dri3 support with loader's dri3 helper")
Spot on - mirrors the xcb_create_pixmap in dri3_create_surface.

Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

If you have a moment, I'd be interested to know why we're creating a X
primitive for pbuffer surface.
IIRC pbuffers are used of off-screen rendering, thus having zero
knowledge/dependency on the underlying platform.

Gut suggests that can drop the pixmap, but I'm likely missing something.

Thanks
Emil