[Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

Emil Velikov emil.l.velikov at gmail.com
Mon Aug 13 14:44:51 UTC 2018


From: Emil Velikov <emil.velikov at collabora.com>

The function name is misleading - it effectively checks if
loader_get_driver_for_fd fails. Which can happen only only on strdup
error - a close to impossible scenario.

Drop the function - we call the loader API at at later stage.

Cc: Robert Foss <robert.foss at collabora.com>
Cc: Tomasz Figa <tfiga at chromium.org>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
 src/egl/drivers/dri2/platform_android.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c
index bea06fd55dd..9f2124fe349 100644
--- a/src/egl/drivers/dri2/platform_android.c
+++ b/src/egl/drivers/dri2/platform_android.c
@@ -1236,19 +1236,6 @@ error:
    return false;
 }
 
-static bool
-droid_probe_driver(int fd)
-{
-   char *driver_name;
-
-   driver_name = loader_get_driver_for_fd(fd);
-   if (driver_name == NULL)
-      return false;
-
-   free(driver_name);
-   return true;
-}
-
 typedef enum {
    probe_fail = -1,
    probe_success = 0,
@@ -1274,11 +1261,6 @@ droid_probe_device(_EGLDisplay *disp, int fd, const char *vendor)
       goto cleanup;
    }
 
-   if (!droid_probe_driver(fd)) {
-      ret = probe_fail;
-      goto cleanup;
-   }
-
    ret = probe_success;
 
 cleanup:
-- 
2.18.0



More information about the mesa-dev mailing list