[Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

Alejandro Piñeiro apinheiro at igalia.com
Mon Aug 13 14:56:01 UTC 2018



On 13/08/18 16:50, Alejandro Piñeiro wrote:
> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this
> patch replaces it with unsigned.
> ---
>
> Note that Im not sure if this is the usual solution. As far as I see,
> uint is used on other source files. Having said so, just replacing for
> unsigned seems the easier way to fix this.

Note2: I don't have a way to really test this patch on MSVC. I assume
that it would fix it, but it is a kind of blind-assumption.


>
>  src/mesa/main/glspirv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
> index 4fc80b72181..1c5b7dd17f3 100644
> --- a/src/mesa/main/glspirv.c
> +++ b/src/mesa/main/glspirv.c
> @@ -188,7 +188,7 @@ nir_compute_double_inputs(nir_shader *shader,
>  {
>     nir_foreach_variable(var, &shader->inputs) {
>        if (glsl_type_is_dual_slot(glsl_without_array(var->type))) {
> -         for (uint i = 0; i < glsl_count_attribute_slots(var->type, true); i++) {
> +         for (unsigned i = 0; i < glsl_count_attribute_slots(var->type, true); i++) {
>              uint64_t bitfield = BITFIELD64_BIT(var->data.location + i);
>              shader->info.vs.double_inputs |= bitfield;
>           }



More information about the mesa-dev mailing list