[Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

[Alejandro Piñeiro]

On 13/08/18 20:43, Dylan Baker wrote:
> This probably should have a Fixes tag?

Yes, should had, but I pushed it as soon as I got a Rb :/ Sorry
>
> Quoting Alejandro Piñeiro (2018-08-13 07:50:38)
>> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this
>> patch replaces it with unsigned.
>> ---
>>
>> Note that Im not sure if this is the usual solution. As far as I see,
>> uint is used on other source files. Having said so, just replacing for
>> unsigned seems the easier way to fix this.
>>
>>  src/mesa/main/glspirv.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
>> index 4fc80b72181..1c5b7dd17f3 100644
>> --- a/src/mesa/main/glspirv.c
>> +++ b/src/mesa/main/glspirv.c
>> @@ -188,7 +188,7 @@ nir_compute_double_inputs(nir_shader *shader,
>>  {
>>     nir_foreach_variable(var, &shader->inputs) {
>>        if (glsl_type_is_dual_slot(glsl_without_array(var->type))) {
>> -         for (uint i = 0; i < glsl_count_attribute_slots(var->type, true); i++) {
>> +         for (unsigned i = 0; i < glsl_count_attribute_slots(var->type, true); i++) {
>>              uint64_t bitfield = BITFIELD64_BIT(var->data.location + i);
>>              shader->info.vs.double_inputs |= bitfield;
>>           }
>> -- 
>> 2.14.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180814/e1a4e4c0/attachment.sig>