[Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

Kenneth Graunke kenneth at whitecape.org
Tue Aug 14 16:09:33 UTC 2018

On Wednesday, August 8, 2018 12:05:00 PM PDT Jason Ekstrand wrote:
> Commit 4434591bf56a6b0 caused substantially more URB messages in
> geometry and tessellation shaders.  Before we can really enable this
> sort of optimization,  We either need some way of combining them back
> together into vectors or we need to do cross-stage vector element
> elimination without splitting everything into scalars.
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107510
> ---
>  src/intel/compiler/brw_nir.c | 17 +++++------------
>  1 file changed, 5 insertions(+), 12 deletions(-)

For TCS outputs, we'd want something like you described.
For various inputs...we should just issue whole-vec4 URB loads
and CSE them.  But we're probably not.  We can fix that.

For now, this seems reasonable.

Acked-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180814/9711ffc8/attachment.sig>

More information about the mesa-dev mailing list