[Mesa-dev] [PATCH mesa 3/3] bin: whitespace cleanup

Dylan Baker dylan at pnwbakers.com
Tue Aug 14 17:41:41 UTC 2018


With the one nit, patches 1 and 3 are:
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

I'm not confident on patch 2 to give you an rb.

Quoting Eric Engestrom (2018-08-14 10:24:13)
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
>  bin/git_sha1_gen.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py
> index bcc29de1c6218ab3af79..dd967a7ee2b654c1ab92 100755
> --- a/bin/git_sha1_gen.py
> +++ b/bin/git_sha1_gen.py
> @@ -42,14 +42,14 @@ def write_if_different(contents):
>  
>  parser = argparse.ArgumentParser()
>  parser.add_argument('--output', help='File to write the #define in',
> -        required=True)
> +                    required=True)
>  args = parser.parse_args()
>  
>  git_sha1 = os.environ.get('MESA_GIT_SHA1_OVERRIDE', get_git_sha1())[:10]
>  if git_sha1:
>      git_sha1_h_in_path = os.path.join(os.path.dirname(sys.argv[0]),
> -            '..', 'src', 'git_sha1.h.in')
> -    with open(git_sha1_h_in_path , 'r') as git_sha1_h_in:
> +                                      '..', 'src', 'git_sha1.h.in')
> +    with open(git_sha1_h_in_path, 'r') as git_sha1_h_in:
>          new_sha1 = git_sha1_h_in.read().replace('@VCS_TAG@', git_sha1)
>          write_if_different(new_sha1)
>  else:
> -- 
> Cheers,
>   Eric
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180814/f2857471/attachment.sig>


More information about the mesa-dev mailing list