[Mesa-dev] [PATCH] radv: drop wrong initialization of COMPUTE_RESOURCE_LIMITS

[Bas Nieuwenhuizen]

On Wed, Aug 15, 2018 at 2:13 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
>
>
> On 8/14/18 9:15 PM, Bas Nieuwenhuizen wrote:
>>
>> On Tue, Aug 14, 2018 at 6:11 PM, Samuel Pitoiset
>> <samuel.pitoiset at gmail.com> wrote:
>>>
>>> The last parameter of radeon_set_sh_reg_seq() is the number of
>>> dwords to emit. We were lucky because WAVES_PER_SH(0x3) is 3 but
>>> it was initialized to 0.
>>>
>>> COMPUTE_RESOURCE_LIMITS is correctly set when generating
>>> compute pipelines, so we don't need to initialize it.
>>
>>
>> Note that there we don't set WAVES_PER_SH. Is that intended?
>
>
> Yeah, I don't think that matters and it wasn't set before anyway.
>
>>
>> Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>>
>> Also a radeonsi patch?
>
>
> Why?

The same wrong patch was applied to radeonsi initialization, no?

>
>
>>
>>>
>>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>>> ---
>>>   src/amd/vulkan/si_cmd_buffer.c | 4 +---
>>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/src/amd/vulkan/si_cmd_buffer.c
>>> b/src/amd/vulkan/si_cmd_buffer.c
>>> index 2337036c67..2cfa7f4c2c 100644
>>> --- a/src/amd/vulkan/si_cmd_buffer.c
>>> +++ b/src/amd/vulkan/si_cmd_buffer.c
>>> @@ -88,9 +88,7 @@ si_emit_compute(struct radv_physical_device
>>> *physical_device,
>>>          radeon_emit(cs, 0);
>>>          radeon_emit(cs, 0);
>>>
>>> -       radeon_set_sh_reg_seq(cs, R_00B854_COMPUTE_RESOURCE_LIMITS,
>>> -                             S_00B854_WAVES_PER_SH(0x3));
>>> -       radeon_emit(cs, 0);
>>> +       radeon_set_sh_reg_seq(cs,
>>> R_00B858_COMPUTE_STATIC_THREAD_MGMT_SE0, 2);
>>>          /* R_00B858_COMPUTE_STATIC_THREAD_MGMT_SE0 / SE1 */
>>>          radeon_emit(cs, S_00B858_SH0_CU_EN(0xffff) |
>>> S_00B858_SH1_CU_EN(0xffff));
>>>          radeon_emit(cs, S_00B85C_SH0_CU_EN(0xffff) |
>>> S_00B85C_SH1_CU_EN(0xffff));
>>> --
>>> 2.18.0
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev