[Mesa-dev] [PATCH] radv: fix missing initialization of the conditional rendering state

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Thu Aug 16 09:33:14 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Thu, Aug 16, 2018 at 11:22 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> This was missing when VK_EXT_conditional_rendering has been
> implemented. The predication type should be -1 to avoid
> restoring previous state when performing a decompression pass
> with DCC enabled.
>
> Note that we don't have to handle secondary command buffers
> because we don't support this feature currently.
>
> CC: 18.2 <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 7785ece8ce..84f7bb42c4 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -2307,6 +2307,7 @@ VkResult radv_BeginCommandBuffer(
>         cmd_buffer->state.last_num_instances = -1;
>         cmd_buffer->state.last_vertex_offset = -1;
>         cmd_buffer->state.last_first_instance = -1;
> +       cmd_buffer->state.predication_type = -1;
>         cmd_buffer->usage_flags = pBeginInfo->flags;
>
>         /* setup initial configuration into command buffer */
> --
> 2.18.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list