[Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

Emil Velikov emil.l.velikov at gmail.com
Fri Aug 17 11:10:55 UTC 2018


On 16 August 2018 at 23:00, Mathieu Bridon <bochecha at daitauha.fr> wrote:
> On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote:
>> ---
>>
>> I didn't see any patches from anyone else, so I wrote some real
>> quick. Please
>> point to them if other patches already exist.
>
> I was about to send mine, but you were faster. >_<
>
> They ar every similar though, except that you missed glcpp_test.py,
> which requires a few more changes. (I have them ready, and can send
> them separately)
>
Yes, please - on the glcpp_test.py fixes.

>> diff --git a/src/compiler/glsl/tests/optimization_test.py
>> b/src/compiler/glsl/tests/optimization_test.py
>> index 577d2dfc20f..f40d0cee6bd 100755
>> --- a/src/compiler/glsl/tests/optimization_test.py
>> +++ b/src/compiler/glsl/tests/optimization_test.py
>> @@ -1,4 +1,4 @@
>> -#!/usr/bin/env python2
>> +#!/usr/bin/env python
Please drop this hunk. I'm removing these all together.

Thanks
Emil


More information about the mesa-dev mailing list