[Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

Iago Toral itoral at igalia.com
Fri Aug 17 13:01:43 UTC 2018


Hi Andrey,
Thanks for the report and all the analysis work on your side. I am on
holidays at the momentand from tomorrow onwards I won't have reliable
internet access but Samuel will be back fromhis vacaction next week and
he might be be able to have a look at the problem and your patch.
Thanks,Iago
On Wed, 2018-08-15 at 18:26 +0300, andrey simiklit wrote:
> Hi all,
> 
> This workaround just helps me to avoid the graphical corruption on
> SNB but
> I not sure is it good idea.
> Regards,
> Andrii.
> 
> On Wed, Aug 15, 2018 at 6:20 PM,  <asimiklit.work at gmail.com> wrote:
> > From: Andrii Simiklit <asimiklit.work at gmail.com>
> > 
> > 
> > 
> > When the SVBI Payload Enable is false I guess the register R1.4
> > 
> > which contains the Maximum Streamed Vertex Buffer Index is filled
> > by zero
> > 
> > and GS stops to write transform feedback when the transform
> > feedback 
> > 
> > is not active.
> > 
> > 
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
> > 
> > Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
> > 
> > ---
> > 
> >  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
> > 
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > 
> > 
> > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
> > b/src/mesa/drivers/dri/i965/genX_state_upload.c
> > 
> > index ea5ad55..0f82500 100644
> > 
> > --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> > 
> > +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> > 
> > @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context
> > *brw)
> > 
> >  #if GEN_GEN < 7
> > 
> >           gs.SOStatisticsEnable = true;
> > 
> >           if (gs_prog->info.has_transform_feedback_varyings)
> > 
> > -            gs.SVBIPayloadEnable = true;
> > 
> > +            gs.SVBIPayloadEnable =
> > _mesa_is_xfb_active_and_unpaused(ctx);
> > 
> > 
> > 
> >           /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are
> > enabled as it
> > 
> >            * was previously done for gen6.
> > 
> > -- 
> > 
> > 2.7.4
> > 
> > 
> > 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180817/dfe91d5f/attachment.html>


More information about the mesa-dev mailing list