[Mesa-dev] [PATCH mesa] i965: drop duplicate assignments

Eric Engestrom eric.engestrom at intel.com
Fri Aug 17 13:02:01 UTC 2018


On Thursday, 2018-08-16 09:39:28 -0700, Caio Marcelo de Oliveira Filho wrote:
> On Thu, Aug 16, 2018 at 04:00:16PM +0100, Eric Engestrom wrote:
> > These are all already assigned when declared, a few lines above.
> > 
> > Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> > ---
> > Note: I'm not 100% certain the value can never change by the time this
> > second assignment is done, so maybe it's the initial one that should be
> > dropped?
> 
> It seems to me the initial ones should be dropped, since the value is
> not used before the second assignment.

Sure, I'll do that then :)

> 
> 
> Thanks,
> Caio


More information about the mesa-dev mailing list