[Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

Emil Velikov emil.l.velikov at gmail.com
Fri Aug 17 16:41:29 UTC 2018


On 15 August 2018 at 13:29, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 6 August 2018 at 04:19, Qiang Yu <Qiang.Yu at amd.com> wrote:
>> This patch series is discussed in thread:
>> https://lists.freedesktop.org/archives/mesa-dev/2018-July/201348.html
>>
>> amdgpu-pro driver can use drirc config to override the mesa radeonsi
>> dri driver so that it can use the mesa libgbm instead of maintain
>> a customized one.
>>
>> We also expand drirc config file location to some directory for the
>> ease of driver and application to add their own config files.
>>
>> v3:
>>   1. split more patches
>>   2. fix dirent mem leak
>>
>> v2:
>>   1. remove /etc/drirc.d
>>   2. move orginal /etc/drirc to /usr/share/drirc.d
>>   3. add kernel_driver device attribute
>>
>> Qiang Yu (6):
>>   xmlconfig: refine driParseConfigFiles to use parseOneConfigFile
>>   xmlconfig: read more config files from drirc.d/
>>   driconf: move ${sysconfdir}/drirc to
>>     ${datadir}/drirc.d/00-mesa-defaults.conf
>>   loader: abstract loader_get_kernel_driver_name for reuse
>>   xmlconfig: add kernel_driver device attribute
>>   loader: add dri_driver option to override dri driver to load
>>
> Pardon for the delay, Qiang Yu  Series looks good and is
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>
> The series has been on the list for a while, Michel seems happy with
> it, so I'm inclined to merge this late today/early tomorrow.
> Please keep an eye open for any bug reports - just a gut feeling.
>
So instead of waiting for reports I've spun this in Travis/Appveyour
and addressed:
- missing include <limits.h> (for PATH_MAX) in patch 1
- added HAVE_LIBDRM guard for __driConfigOptionsLoader and
loader_get_dri_config_driver

In theory, one should be able to build with driconf and w/o libdrm,
and vice-versa.
If you have some time, please have a look - is it possible, would it
make sense, etc.

Thanks
Emil


More information about the mesa-dev mailing list