[Mesa-dev] [PATCH 11/13] intel/compiler: Implement untyped atomic float min, max, and compare-swap dataport messages

Caio Marcelo de Oliveira Filho caio.oliveira at intel.com
Fri Aug 17 23:42:16 UTC 2018


On Fri, Jun 22, 2018 at 10:03:56PM -0700, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Also expand the message type field by a single bit.  This is necessary
> for this Gen9 message type, but there are also Gen8 message types that
> need the extra bit (mostly for bindless).

I'd consider splitting this particular change in its own commit, but
not a strong opinion.


> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/intel/compiler/brw_disasm.c                   |  15 +++-
>  src/intel/compiler/brw_eu.h                       |  11 +++
>  src/intel/compiler/brw_eu_defines.h               |  12 ++-
>  src/intel/compiler/brw_eu_emit.c                  |  48 ++++++++++
>  src/intel/compiler/brw_fs.cpp                     |  23 +++++
>  src/intel/compiler/brw_fs.h                       |   4 +
>  src/intel/compiler/brw_fs_copy_propagation.cpp    |   2 +
>  src/intel/compiler/brw_fs_dead_code_eliminate.cpp |   2 +
>  src/intel/compiler/brw_fs_generator.cpp           |   7 ++
>  src/intel/compiler/brw_fs_nir.cpp                 | 103 ++++++++++++++++++++++
>  src/intel/compiler/brw_fs_surface_builder.cpp     |  24 +++++
>  src/intel/compiler/brw_fs_surface_builder.h       |   7 ++
>  src/intel/compiler/brw_inst.h                     |   2 +-
>  src/intel/compiler/brw_schedule_instructions.cpp  |   1 +
>  src/intel/compiler/brw_shader.cpp                 |   6 ++
>  15 files changed, 264 insertions(+), 3 deletions(-)


Regardless of the suggestion above, this patch is

Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>




More information about the mesa-dev mailing list