[Mesa-dev] [PATCH 12/13] i965: Sort Gen9+ extension enables

[Caio Marcelo de Oliveira Filho]

This patch is

Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>



On Fri, Jun 22, 2018 at 10:03:57PM -0700, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> This is a strictly alphabetic sort, as is done in extensions_table.h
> There are other options.  We should pick one and document it.  Right
> now, this file is chaos.

It seems part of the chaos comes from the various individual blocks /
conditions. Maybe doing the other way around would be better,
i.e. having a list of extensions in alphabetical order, set to the
conditions they need to meet.

    ctx->Extensions.ARB_shader_viewport_layer_array = devinfo->gen >= 7 && ctx->API == API_OPENGL_CORE;

possibly using a local macro and/or variables (for common conditions) to
make things less noisy.  Just a random example to show the potential:

    e->ARB_shader_viewport_layer_array = gen >= 7 && api_opengl_core;