[Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

Emil Velikov emil.l.velikov at gmail.com
Sat Aug 18 10:50:25 UTC 2018


On 17 August 2018 at 18:55, Dylan Baker <dylan at pnwbakers.com> wrote:
> I don't care one way or the other on this, but it needs to wait for the series I
> have to make two of the test cases py 3 ready, and for a patch from Mathieu to
> make another py 3 ready.
>
> Just for reference, it is convention (though I don't care to keep it) to use
> such a shebang to mark whether a script is python2, python3, or both (using
> python is supposed to mean python 2 and 3 compatible.)
>
> You have my r-b, but please wait to push thisfor the other patches to land or
> you'll break the meson build and make Mark and Clayton grumpy:
> Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
>
Thank you and I fully agree.

These are to land _after_ the python scripts are updated.
I wanted to get these our since they will make missing conversions a
lot more obvious.

-Emil


More information about the mesa-dev mailing list