[Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

[Emil Velikov]

On 18 August 2018 at 04:37, Yu, Qiang <Qiang.Yu at amd.com> wrote:
> Thanks Emil.
>
Ftr both of those did show up with the MacOS build on Travis.
If you have a github account you easily experiment it.

>> - missing include <limits.h> (for PATH_MAX) in patch 1
> Although I can compile without <limits.h>, I agree to add it explicitly.
>
>> - added HAVE_LIBDRM guard for __driConfigOptionsLoader and
>> loader_get_dri_config_driver
> My thoughts are:
> 1. __driConfigOptionsLoader and loader_get_dri_config_driver don't
> have code depend on HAVE_LIBDRM (loader_get_kernel_driver_name
> does but already has HAVE_LIBDRM), so it's OK to drop HAVE_LIBDRM
> 2. if drop HAVE_LIBDRM, user can still use dri_driver option to change
> dri driver to load even on non-libdrm env (although I'm not clear if this
> kind of env need this functionality)
>
Currently the includes at the atop are nested - if have_libdrm;
include; if use_dri; include; endif; endif

As mentioned earlier, unwrapping that should be possible. Yet it
requires more time than I could spend on the topic.
Patches would be greatly appreciated.

-Emil