[Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

Emil Velikov emil.l.velikov at gmail.com
Sat Aug 18 12:40:36 UTC 2018

On 18 August 2018 at 13:02, Eric Engestrom <eric.engestrom at intel.com> wrote:
> On Saturday, 2018-08-18 12:25:42 +0100, Eric Engestrom wrote:
>> On Friday, 2018-08-17 10:55:28 -0700, Dylan Baker wrote:
>> > I don't care one way or the other on this, but it needs to wait for the series I
>> > have to make two of the test cases py 3 ready, and for a patch from Mathieu to
>> > make another py 3 ready.
>> >
>> > Just for reference, it is convention (though I don't care to keep it) to use
>> > such a shebang to mark whether a script is python2, python3, or both (using
>> > python is supposed to mean python 2 and 3 compatible.)
>> Yeah, for that reason I'd rather keep them...
>> Not a nack either, just personal preference, and since they're probably
>> not correct with that regard anyway... meh
> To be clear, I'm definitely in favour of dropping the execute bit though, and
> thinking about it, I've changed my mind: let's drop the shebang as well.
> Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Ack, thank you.
Fwiw to get the best of both (hint, yet do not mandate) Arch applied
something like s/env/hint/ in shebang line on bash scripts ;-)


More information about the mesa-dev mailing list