[Mesa-dev] [PATCH 00/12] Compiler warning fixes, round 2
Lionel Landwerlin
lionel.g.landwerlin at intel.com
Sun Aug 19 09:05:45 UTC 2018
Hi Kai,
Patches 6, 7, 10 & 11 are :
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
There are 2 existing series touching the same code, in patches 8, 9 &
12, I think should land before the warnings are fixed.
Thanks,
-
Lionel
On 18/08/18 12:16, Kai Wasserbäch wrote:
> Hey,
> thanks to Bas and Timothy for reviewing and pushing most of my previous
> warning fixes series (<https://patchwork.freedesktop.org/series/48403/>)!
>
> I just continued down the build log and fixed the next eleven warnings.
> These changes are, again, compile-tested in a clean chroot (pbuilder) on
> amd64 and i386.
>
> You can find the signed commits on the FDO GitLab at
> <https://gitlab.freedesktop.org/curan/mesa/commits/fix-warnings2>.
>
> Note: the first patch is a resend of patch four of the previous series,
> as it hasn't been reviewed/accepted so far and I thought it would be
> easier to keep only one series active.
>
> Please review and, if you should accept these patches, please commit
> them for me, as I do not have commit access for Mesa.
>
> Cheers,
> Kai
>
>
> Kai Wasserbäch (12):
> amd/addrlib: mark returnCode as MAYBE_UNUSED in ElemGetExportNorm
> amd/addrlib: mark microBlockDim as MAYBE_UNUSED in
> Addr::V2::Gfx9Lib::HwlComputeBlock256Equation
> amd/addrlib: mark *pEqToCheck as MAYBE_UNUSED in
> Addr::V2::Gfx9Lib::ComputeStereoInfo
> amd/addrlib: mark numPipes as MAYBE_UNUSED in
> Addr::V1::EgBasedLib::SanityCheckMacroTiled
> amd/addrlib: mark physicalSliceSize as MAYBE_UNUSED in
> Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled
> intel/aubinator_error_decode: mark ret as MAYBE_UNUSED in main
> intel: aubinator: mark ftruncate_res as MAYBE_UNUSED in
> ensure_phys_mem
> intel: aubinator: mark *res as MAYBE_UNUSED in get_ggtt_batch_bo
> intel: aubinator: mark *res as MAYBE_UNUSED in get_ppgtt_batch_bo
> intel/tools: initialise bo_addr to 0 in main
> intel/decoder: mark total_length as MAYBE_UNUSED in gen_spec_load
> intel/decoder: mark result as MAYBE_UNUSED in gen_field_iterator_next
>
> src/amd/Makefile.addrlib.am | 1 +
> src/amd/addrlib/addrinterface.cpp | 4 +++-
> src/amd/addrlib/gfx9/gfx9addrlib.cpp | 16 +++++++++-------
> src/amd/addrlib/r800/egbaddrlib.cpp | 8 +++++---
> src/intel/common/gen_decoder.c | 5 +++--
> src/intel/tools/aubinator.c | 12 +++++++-----
> src/intel/tools/aubinator_error_decode.c | 2 +-
> src/intel/tools/error2aub.c | 2 +-
> 8 files changed, 30 insertions(+), 20 deletions(-)
>
More information about the mesa-dev
mailing list