[Mesa-dev] [PATCH 10/22] nir/format_convert: Fix a bitmask in unpack_11f11f10f

Kenneth Graunke kenneth at whitecape.org
Mon Aug 20 07:46:28 UTC 2018


On Friday, August 17, 2018 1:06:16 PM PDT Jason Ekstrand wrote:
> Fixes: 4e337b42f9a2 "nir/format_convert: Add pack/unpack for R11F_G11F_B10F"
> ---
>  src/compiler/nir/nir_format_convert.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/nir/nir_format_convert.h b/src/compiler/nir/nir_format_convert.h
> index c79001a50aa..27a8ac08d49 100644
> --- a/src/compiler/nir/nir_format_convert.h
> +++ b/src/compiler/nir/nir_format_convert.h
> @@ -288,7 +288,7 @@ nir_format_unpack_11f11f10f(nir_builder *b, nir_ssa_def *packed)
>  {
>     nir_ssa_def *chans[3];
>     chans[0] = nir_mask_shift(b, packed, 0x000007ff, 4);
> -   chans[1] = nir_mask_shift(b, packed, 0x003ff100, -7);
> +   chans[1] = nir_mask_shift(b, packed, 0x003ff800, -7);
>     chans[2] = nir_mask_shift(b, packed, 0xffc00000, -17);
>  
>     for (unsigned i = 0; i < 3; i++)
> 

Patches 9-10 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180820/be29ff11/attachment-0001.sig>


More information about the mesa-dev mailing list