[Mesa-dev] [PATCH] appveyor: Set git core.autocrlf setting to true.

Jose Fonseca jfonseca at vmware.com
Mon Aug 20 11:21:15 UTC 2018

The git core.autocrlf setting defaults to true (ie, all text files get
checked out as CRLF on Windows), except on Appveyor where's set to
"input" (ie, all text files get checked out with the upstream
repository's line endings, which for us typically means LF.)

And this was masking on Appveyor a regression in gen_xmlpool.py
processing t_options.h with CRLF line endings.

This change makes core.autocrlf to be true, which would have enabled to
immediately catch the issue, as seen in
 appveyor.yml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/appveyor.yml b/appveyor.yml
index 86440f0d76a..73be3c57df8 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -39,11 +39,18 @@ cache:
 os: Visual Studio 2015
+# Appveyor defaults core.autocrlf to input instead of the default (true), but
+# that can hide problems processing CRLF text on Windows
+- git config --global core.autocrlf true
   WINFLEXBISON_ARCHIVE: win_flex_bison-2.5.9.zip
   LLVM_ARCHIVE: llvm-5.0.1-msvc2015-mtd.7z
+# Check git config
+- git config core.autocrlf
 # Check pip
 - python --version
 - python -m pip --version

More information about the mesa-dev mailing list