[Mesa-dev] i915/swrast vertex array regression

[Ville Syrjälä]

On Fri, Aug 10, 2018 at 01:13:31PM +0200, Mathias Fröhlich wrote:
> Hi Ville,
> 
> > Looks like
> > "vid_gl20" "0"
> > is needed to reproduce the issue.
> 
> Thanks! Now I can observe the problem!
> And the attached patch seems to fix what I can observe here.
> Does the attached patch also fix the problem with the
> older intel chip you originally reported?

Seems to. Thanks for tracking it down.

Tested-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> 
> Thanks!
> 
> Mathias

> From 68e921478c8c38a13b7258e0d3f1f235709dcfe9 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Mathias=20Fr=C3=B6hlich?= <mathias.froehlich at web.de>
> Date: Fri, 10 Aug 2018 11:37:43 +0200
> Subject: [PATCH] tnl: Fix green gun regression in xonotic.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Signed-off-by: Mathias Fröhlich <Mathias.Froehlich at web.de>
> ---
>  src/mesa/tnl/t_split_copy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/tnl/t_split_copy.c b/src/mesa/tnl/t_split_copy.c
> index cbb7eb409f..085ae9a28c 100644
> --- a/src/mesa/tnl/t_split_copy.c
> +++ b/src/mesa/tnl/t_split_copy.c
> @@ -531,7 +531,7 @@ replay_init(struct copy_context *copy)
>     for (offset = 0, i = 0; i < copy->nr_varying; i++) {
>        const struct tnl_vertex_array *src = copy->varying[i].array;
>        const struct gl_array_attributes *srcattr = src->VertexAttrib;
> -      struct tnl_vertex_array *dst = &copy->dstarray[i];
> +      struct tnl_vertex_array *dst = &copy->dstarray[copy->varying[i].attr];
>        struct gl_vertex_buffer_binding *dstbind = &copy->varying[i].dstbinding;
>        struct gl_array_attributes *dstattr = &copy->varying[i].dstattribs;
>  
> -- 
> 2.17.1
> 


-- 
Ville Syrjälä
Intel