[Mesa-dev] [PATCH] i965: Advertise 8 bits subpixel precision for viewport bounds on gen6+

Lionel Landwerlin lionel.g.landwerlin at intel.com
Tue Aug 21 08:14:54 UTC 2018


Hey Andres,

Yes, it should. Sorry I missed the Cc stable in the patch.

Thanks for paying attention :)

-
Lionel

On 20/08/2018 23:17, Andres Gomez wrote:
> Danylo, should we also include this in the stable queues ?
>
>
> On Mon, 2018-06-18 at 15:50 +0300, Danylo Piliaiev wrote:
>> We use floating-points for viewport bounds so VIEWPORT_SUBPIXEL_BITS
>> should reflect this.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105975
>>
>> Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
>> ---
>>   src/mesa/drivers/dri/i965/brw_context.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
>> index 9ced230..eacf326 100644
>> --- a/src/mesa/drivers/dri/i965/brw_context.c
>> +++ b/src/mesa/drivers/dri/i965/brw_context.c
>> @@ -688,7 +688,7 @@ brw_initialize_context_constants(struct brw_context *brw)
>>      /* ARB_viewport_array, OES_viewport_array */
>>      if (devinfo->gen >= 6) {
>>         ctx->Const.MaxViewports = GEN6_NUM_VIEWPORTS;
>> -      ctx->Const.ViewportSubpixelBits = 0;
>> +      ctx->Const.ViewportSubpixelBits = 8;
>>   
>>         /* Cast to float before negating because MaxViewportWidth is unsigned.
>>          */




More information about the mesa-dev mailing list