[Mesa-dev] [PATCH] meson: fix egl build for surfaceless and android

Dylan Baker dylan at pnwbakers.com
Wed Aug 22 18:31:07 UTC 2018


Both of these changes look correct to me, could you split them into two separate
patches though? To the one that adds inc_loader to surfaceless add:
Fixes: 108d257a16859898f5ce02f4759c5c58f9b8c050 ("meson: build libEGL")

To the one that adds it for android add:
Fixes: c5ec1556859b7d33637c9fad13d3473c7b2f9eb3 ("meson: wire up egl/android")

Please CC me on the v2 and I'll get it merged promptly.

Thanks,
Dylan

Quoting Gurchetan Singh (2018-08-22 10:48:06)
> Without this, I get:
> 
>  > platform_surfaceless.c:38:10: fatal error: 'loader.h' file not found
>  > #include "loader.h"
>  >      ^~~~~~~~~~
>  > 1 error generated.
> 
> I also included this for platform_android, but I haven't tested that
> case.
> ---
>  src/egl/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/egl/meson.build b/src/egl/meson.build
> index c7c22d3637..06922c6c3c 100644
> --- a/src/egl/meson.build
> +++ b/src/egl/meson.build
> @@ -114,6 +114,7 @@ if with_platform_drm
>  endif
>  if with_platform_surfaceless
>    files_egl += files('drivers/dri2/platform_surfaceless.c')
> +  incs_for_egl += [inc_loader]
>  endif
>  if with_platform_wayland
>    deps_for_egl += [dep_wayland_client, dep_wayland_server, dep_wayland_egl_headers]
> @@ -129,6 +130,7 @@ endif
>  if with_platform_android
>    deps_for_egl += dep_android
>    files_egl += files('drivers/dri2/platform_android.c')
> +  incs_for_egl += [inc_loader]
>  endif
>  if with_platform_haiku
>    incs_for_egl += inc_haikugl
> -- 
> 2.16.4
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180822/1c0173d2/attachment.sig>


More information about the mesa-dev mailing list