[Mesa-dev] [PATCH v4 46/49] appveyor: use chocolatey (cinst) to install winflexbison

[Dylan Baker]

Quoting Jose Fonseca (2018-08-22 11:39:12)
> On 22/08/18 18:05, Dylan Baker wrote:
> > v2: - fix typos in commit message
> > ---
> >   appveyor.yml | 6 +-----
> >   1 file changed, 1 insertion(+), 5 deletions(-)
> > 
> > diff --git a/appveyor.yml b/appveyor.yml
> > index 15a31da9411..b26a3c624e8 100644
> > --- a/appveyor.yml
> > +++ b/appveyor.yml
> > @@ -34,7 +34,6 @@ branches:
> >   clone_depth: 100
> >   
> >   cache:
> > -- win_flex_bison-2.5.9.zip
> >   - llvm-5.0.1-msvc2015-mtd.7z
> >   - subprojects\packagecache
> >   
> > @@ -46,7 +45,6 @@ init:
> >   - git config --global core.autocrlf true
> >   
> >   environment:
> > -  WINFLEXBISON_ARCHIVE: win_flex_bison-2.5.9.zip
> >     LLVM_ARCHIVE: llvm-5.0.1-msvc2015-mtd.7z
> >     matrix:
> >       - BUILD_SYSTEM: meson
> > @@ -72,9 +70,7 @@ install:
> >   - if "%BUILD_SYSTEM%"=="meson" ninja --version
> >   - if "%BUILD_SYSTEM%"=="meson" call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x86
> >   # Install flex/bison
> > -- if not exist "%WINFLEXBISON_ARCHIVE%" appveyor DownloadFile "https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownloads.sourceforge.net%2Fproject%2Fwinflexbison%2Fold_versions%2F%25WINFLEXBISON_ARCHIVE%25&data=02%7C01%7Cjfonseca%40vmware.com%7C075d2af0e3d4415da59f08d6085217c0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636705546029228240&sdata=yX%2BTOaizEhvzgHGwArmD4BQcJ54Tr5FCo8H6jFX1DN0%3D&reserved=0"
> > -- 7z x -y -owinflexbison\ "%WINFLEXBISON_ARCHIVE%" > nul
> > -- set Path=%CD%\winflexbison;%Path%
> > +- cinst -y winflexbison
> >   - win_flex --version
> >   - win_bison --version
> >   # Download and extract LLVM
> > 
> 
> I'm afraid this is a bad idea, because AppVeyor -> SourceForge downloads 
> are not very reliable.
> 
> IIRC, we used to get winflex via cinst, but abandoned because of this.
> 
> Jose

That is very unfortunate, manually downloading and unpacking files and setting
PATH is such a pain compared to a simple cinst. I'll go ahead and drop this
patch.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180823/f78feaf5/attachment-0001.sig>