[Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

Emil Velikov emil.l.velikov at gmail.com
Thu Aug 23 17:57:09 UTC 2018

On Thu, 23 Aug 2018 at 18:41, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi Fritz,
> On Wed, 22 Aug 2018 at 23:01, Fritz Koenig <frkoenig at google.com> wrote:
> >
> > In the GL_MESA_framebuffer_flip_y implementation
> > _mesa_is_winsys_fbo checks were replaced with
> > FlipY checks.  rb->Name is also used to determine
> > if a buffer is winsys.
> This seems like it fixes your earlier patch, so you normally want a
> fixes tag. Something like the following should be fine.
> It adds nice reference tracking, allowing the release manager to track
> and land in the correct stable branches.
> Fixes: ab05dd183cc ("i965: implement GL_MESA_framebuffer_flip_y [v3]")
Quick grep shows a number of rb->Name instances in intel_fbo.c - DBG
and assert statements.
If they should stay as-is, perhaps it'll be better to add some comments?

Just a fly-by idea.

More information about the mesa-dev mailing list